Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENTS] - Monitoring statistics persists when container restarts #505

Closed
dnielso5 opened this issue Jan 30, 2025 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@dnielso5
Copy link

Is your feature request related to a problem? Please describe.
My server has a nightly backup which restarts Portainer, when Portainer turns back on the monitoring statistics start over.

Describe the solution you'd like
statistics do not restart

@dnielso5 dnielso5 added the enhancement New feature or request label Jan 30, 2025
@tobychui
Copy link
Owner

tobychui commented Feb 3, 2025

This sounds like a docker issue to me.

The signals SIGKILL and SIGSTOP may not be caught by a program
https://pkg.go.dev/os/signal

We use signal package to catch the shutdown signal for Zoraxy. If you are sending the interrupt signal into Zoraxy correctly, it should be able to save the statistic data to file.

@PassiveLemon would you mind to take a look at this? Or if you need a new API (to save statistic from docker or some external event?) please feel free to let me know :)

@PassiveLemon
Copy link
Collaborator

Sounds like #133 again, this probably is happening again because I'm starting Zoraxy through the entrypoint script... will look into this

@tobychui
Copy link
Owner

tobychui commented Feb 8, 2025

Should be fixed with the PR mentioned above. Closing this now.

@tobychui tobychui closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants