Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai: support for "reasoning_effort" for o1/o3 models #1129

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Hades32
Copy link

@Hades32 Hades32 commented Feb 3, 2025

Adds support of the reasoning effort field for reasoning models.

See https://platform.openai.com/docs/api-reference/chat/create#chat-create-reasoning_effort

Fixes #1122

Also makes removes temperature for reasoning models. The real fix here would be to change that parameter to be nullable everywhere since omitting it is different from setting zero, but this is outside the scope if this PR

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@Hades32 Hades32 marked this pull request as draft February 3, 2025 16:49
@Hades32 Hades32 marked this pull request as ready for review February 3, 2025 17:07
@Hades32
Copy link
Author

Hades32 commented Feb 4, 2025

@tmc do you agree with the approach here, or should this be on the model level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reasoning_effort param for openai
1 participant