Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UndefVarError: setverbose not defined #977

Closed
yng87 opened this issue Sep 19, 2022 · 2 comments
Closed

UndefVarError: setverbose not defined #977

yng87 opened this issue Sep 19, 2022 · 2 comments
Labels
bug Something isn't working liveserver

Comments

@yng87
Copy link

yng87 commented Sep 19, 2022

Hi, thanks for developing the great package. Using the latest Franklin.jl, I encountered the following error

# in empty project
pkg> add Franklin
julia> using Franklin
julia> newsite("MyNewSite")
julia> serve()
  Activating project at `~/workspace/example-franklin/MyNewSite`
 Initial full pass...
 evaluating code [ex3] in (menu1.md)                                                                                                                                                                                                                                                                                             Starting the server...
ERROR: UndefVarError: setverbose not defined
Stacktrace:
 [1] serve(; clear::Bool, verb::Bool, port::Int64, single::Bool, prerender::Bool, nomess::Bool, is_final_pass::Bool, no_fail_prerender::Bool, eval_all::Bool, silent::Bool, cleanup::Bool, on_write::Franklin.var"#246#249", log::Bool, host::String, show_warnings::Bool, fail_on_warning::Bool, launch::Bool, no_set_paths::Bool, join_to_prepath::String)
   @ Franklin ~/.julia/packages/Franklin/4iv1F/src/manager/franklin.jl:137
 [2] serve()
   @ Franklin ~/.julia/packages/Franklin/4iv1F/src/manager/franklin.jl:49
 [3] top-level scope
   @ REPL[7]:1

It seems there is no setverbose function, and it is probably due to this PR
JuliaDocs/LiveServer.jl#150
I am using Franklin v0.10.78, and the Manifest shows it uses LiveServer.jl v1.0.1.

I could make PR, but I don't know how backward compatibility should be maintained for older LiverServer.jl packages.

@tlienart
Copy link
Owner

Thanks a lot for flagging this.

I did a patch release with LiveServer so that setverbose exist. This is dirty but given that, one day or another, the new 'major' version of Franklin will be released, I'm not too fussed about it.

@yng87
Copy link
Author

yng87 commented Sep 19, 2022

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working liveserver
Projects
None yet
Development

No branches or pull requests

2 participants