Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline svg url not working with Franklin because changed by compression #922

Closed
schlichtanders opened this issue Nov 8, 2021 · 2 comments
Labels

Comments

@schlichtanders
Copy link

On Franklin server everything just works, but when deploying to gitlab, my background heropatterns (svg images inlined into background-image: url(...)) just don't show up.

Inspecting the issue it turns out that something in the pipeline deleted the surrounding quotes. Unbelievable...

So on my local system I have

background-image: url("data:image/svg+xml,...");

which somehow ends up on gitlab pages as

background-image: url(data:image/svg+xml,...);

no surrounding quotes any longer.

Any help is highly appreciated, as this seems to be due to the standard Franklin gitlab pipeline.

@schlichtanders
Copy link
Author

Turning off minify fixed this issue as well.
See #921 (comment)

I would vote for turning off minify by default for everyone.

@tlienart
Copy link
Owner

tlienart commented Nov 8, 2021

yes so as per other issue, minification will be turned off for everyone (prerendering as well btw even though it causes much fewer issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants