Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: hitting 404 does not change the variables nor the path #900

Closed
schlichtanders opened this issue Oct 13, 2021 · 2 comments
Closed

Bug: hitting 404 does not change the variables nor the path #900

schlichtanders opened this issue Oct 13, 2021 · 2 comments

Comments

@schlichtanders
Copy link

I try to separate a landingpage from other pages by using the path or a variable, it seems both does not work when a link points to a non-existing page.

The path does not change to {{url_root}}/404/ but stays the same, say {{url_root}}/ in case our links are on the index page, which is probably the reason for this unfortunate behaviour.

Here my suggestion:

  • switch the path to the href path which was not found (e.g. if you would like to jump to page {{url_root}}/mysecondpage/, but this page does not exist, then 404 should appear instead, so having path {{url_root}}/mysecondpage/
  • correctly switch the variable scope to use the variables from 404.md or the global config in case of an 404.html
@schlichtanders
Copy link
Author

schlichtanders commented Oct 13, 2021

it seems my setting is a bit confused... now the variables work indeed (don't know why they haven't before) so all fine

(maybe it was due to me moving the 404.md to a subdirectory, which run into the other bug that _site is not properly cleaned up, so I always got the old outdated 404)

The path issue still exists though

@schlichtanders
Copy link
Author

Seems to be fixed right now. Not sure whether this is because of an update to Franklin or by some other combinations.

Will keep an eye on this whether it appears again in the future, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant