Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring how to build the page #520

Closed
findmyway opened this issue Jun 10, 2020 · 1 comment
Closed

Allow configuring how to build the page #520

findmyway opened this issue Jun 10, 2020 · 1 comment

Comments

@findmyway
Copy link
Contributor

findmyway commented Jun 10, 2020

Currently, we have a build_page function to merge the head, content and foot into a page:

build_page(head::String, content::String, pgfoot::String, foot::String) =
    head * html_div(locvar("div_content"), content * pgfoot) * foot

Though the class attribute is customizable, one may also need to set other attributes, or even change the node name.

A not so aggressive solution is to change the html_div function into html_hk, like https://github.com/tlienart/Franklin.jl/pull/519/files

Or can we just provide a whole configurable page like below?:

// page.html
{{insert head.html}}
{{ content }}
{{ insert pgfoot.html }}
{{ insert foot.html }}
@findmyway
Copy link
Contributor Author

Closed with #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant