Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring a folder #376

Closed
Wikunia opened this issue Feb 25, 2020 · 10 comments · Fixed by #383
Closed

Ignoring a folder #376

Wikunia opened this issue Feb 25, 2020 · 10 comments · Fixed by #383

Comments

@Wikunia
Copy link
Contributor

Wikunia commented Feb 25, 2020

Currently I have a folder which holds some information for plugins I wrote. That was no problem before as only the pages/ folder was used for serving the page but now Franklin checks every folder and tries to serve it. As mentioned in slack I can move the folder to _assets but in general it might be a nice idea to ignore certain folders using a @def ignore_folders or something like that.

@Wikunia
Copy link
Contributor Author

Wikunia commented Feb 25, 2020

By ignoring I also mean that it will not copied over to __site which is currently the case when having it in _assets.

@MarcMush
Copy link
Contributor

or maybe a .fdignore file, similar to a .gitignore

@Wikunia
Copy link
Contributor Author

Wikunia commented Apr 6, 2020

The @def ignore doesn't seem to work anymore.
Have you changed the structure somehow?
I have @def ignore = ["git-repos/"] in my config.md but when I run serve() I get an error that I have

``@docs 
....
``

in one of the files inside that folder. (`` -> 3 of them but can't show that here I think 😄 )
I can even specify the complete path to the file in @def ignore but still get an error.

All I did was:

] add Franklin
using Franklin
serve()

in the root directory.

Thanks in advance!

@Wikunia
Copy link
Contributor Author

Wikunia commented Apr 6, 2020

Okay there is more wrong. I think the entire config.md is ignored. Everything I defined in there is not useable. For example I have

\newcommand{\note}[1]{@@note @@title ⚠ Note@@ @@content #1 @@ @@}

and in one of my posts:

\note{...}

and get the error

Franklin.LxComError("Command '\\note' was used before it was defined.")

This first appeared in v0.6.15.

@tlienart tlienart reopened this Apr 6, 2020
@tlienart
Copy link
Owner

tlienart commented Apr 6, 2020

Do you have a repo with the code somewhere? it will be helpful to investigate. The config.md should definitely not be ignored.

Note: to have backticks in GitHub, use five of them for the outer block

```julia
 x+1
```

@Wikunia
Copy link
Contributor Author

Wikunia commented Apr 6, 2020

Not at the moment but I'll create it on GitHub and invite you.

@Wikunia
Copy link
Contributor Author

Wikunia commented Apr 6, 2020

You should have an invite now. The ignore folder is also in gitignore but you can just create a folder git-repos with a .md file and some markdown error inside 😄

@tlienart
Copy link
Owner

tlienart commented Apr 6, 2020

Yeah so the issue was with comment lines like <!--------------------- which are now forbidden, this <!-- --------------- (note the whtiespace) is allowed. Closing now (see PR in your repo @Wikunia ).

@tlienart tlienart closed this as completed Apr 6, 2020
@Wikunia
Copy link
Contributor Author

Wikunia commented Apr 6, 2020

Perfect thanks. Additionally you probably want to add ignore to the documentation. Haven't found it there.

@tlienart
Copy link
Owner

tlienart commented Apr 6, 2020

yeah it's on the (ever longer) list of things to add to the docs: #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants