Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + c does not stop serve() on windows #154

Closed
danmrc opened this issue May 26, 2019 · 4 comments
Closed

Ctrl + c does not stop serve() on windows #154

danmrc opened this issue May 26, 2019 · 4 comments

Comments

@danmrc
Copy link

danmrc commented May 26, 2019

Hi,

I am using this package and I followed the manual and tried to stop serve() using ctrl + c and it did not work. It really does nothing at all. I tried both on atom and on the console. I am using windows 10 and Julia 1.1.

Besides that, I would like to suggest two things:

  1. Anti virus do not like this package. I am using a computer with Avast and using serve() and I could not open the site on localhost:8000 (I tried other ports as well). It keeps loading forever and does not even return an error that it could not be reached. White listing the folder where JuDoc is installed solved the problem. Might be useful for other windows users.

  2. If you don't set the directory created by the newsite as the working directory, the serve()command returns an "unknown error". When you run the newsite it looks like it changes the working directory. While I am not sure if the error message could be improved, this might be addressed in the documentation

This is a really good package!

Thanks

@tlienart
Copy link
Owner

tlienart commented May 27, 2019

Hello Daniel, thanks a lot for reporting!

With respect to your second suggestion, yes you have to be inside the website/ directory in order for serve() to work. I agree that a clearer error message should be thrown if that's not the case & I'll open an issue to fix that. Thanks!

CTRL+C and avast

I believe these issues have to do with LiveServer.jl, to make sure could you please try the first block of code in the readme: https://github.com/asprionj/LiveServer.jl and report whether CTRL+C interrupts the server properly? If not, could you please open an issue there and I'll try to figure it out there with you?
I'm unsure why CTRL+C wouldn't work on windows, I had tried in the past on windows but it's windows server 2016 so probably not the same :/

Edit: what happens if you press CTRL+C twice in a quick succession?

The issue with your anti-virus also has to do with LiveServer but given I both don't have windows nor avast it's a bit of poking in the dark, could you report whether one of those does the job:

Also, you seem to say that just entering the address of the files in your browser works? Does everything work fine? (CSS, KaTeX etc?)

Thanks!

PS: I apologise in advance for errors both with LiveServer and JuDoc on Windows, while I did do some testing on windows, I don't have regular access to a machine and use a flimsy VM on the cloud so it's quite likely there will be a few snags... but I'm very grateful for bug reports!

@tlienart
Copy link
Owner

tlienart commented Jun 3, 2019

@danmrc could you update me on whether you were able to try the example from LiveServer? thanks!

@danmrc
Copy link
Author

danmrc commented Jun 5, 2019

Sorry for the delay, I only have Windows on the desktop.

After some use I've discovered that the interrupt works erratic. Sometimes it does work. Sometimes it doesn't. It doesn't matter if I am using Atom or the terminal.

I tried the example of the liveserver. Ctrl + c throws a fatal error and crashes Julia. I guess I should open an issue there.

On avast: both links deal with Avast security suite. I was not clear on it, but I have the free version. I don't have the avast firewall (first link) and I could connect to Jupyter Notebooks (which also uses a localhost). I tried changing the windows firewall configuration and it didn't work. I tried changing the port to the same port of Jupyter, which also didn't work. What did work was whitelisting the package directory. This is a relatively new install (less then a year), so I guess this is a trouble with avast. (On a side note, shortly after this happened avast decided that Julia was a virus)

@tlienart
Copy link
Owner

tlienart commented Jun 6, 2019

Thanks for reporting, I've opened an issue on LiveServer (JuliaDocs/LiveServer.jl#78) if you could copy paste the error messages you have seen + explain your problems there, that would be very helpful!

I'm not sure how quickly we'll be able to fix that as on my Windows VM everything seems to work as it should 😕 but I think Jonas also has access to a windows 10 machine so maybe he'll be able to chip in.

I'm closing this here as it's not related to JuDoc but hope we can fix this in LiveServer. Cheers!

PS:

so I guess this is a trouble with avast. (On a side note, shortly after this happened avast decided that Julia was a virus)

Hahahaha omg...

@tlienart tlienart closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants