[BUG] Upgrading Over Minor Fix (0.10.85 -> 0.10.91) Broke Deployment

[TheCedarPrince]

Hi @tlienart ,

Yesterday, I was attempting a deployment of our JuliaHealth website and for some reason, the deployment failed arbitrarily. I wrote up details in this issue here: JuliaHealth/juliahealth.github.io#114

I was able to track down the issue with some tips from @DilumAluthge and determined the issue was from us upgrading the Franklin version we used in deployment. We migrated recently from 0.10.85 -> 0.10.91 and somewhere, the breakage occurred. I pinned the last version that worked (0.10.85) and sure enough, no deployment issues.

The issue I linked had even more information, but from the GH Action logs, here is what I see as an error in the deployment:

ERROR: LoadError: LoadError: syntax: invalid keyword argument syntax "shortcut"
Stacktrace:
 [1] top-level scope at /home/runner/.julia/packages/Franklin/xhxut/src/eval/codeblock.jl:84
 [2] include(::Module, ::String) at ./Base.jl:377
 [3] include(::String) at /home/runner/.julia/packages/Franklin/xhxut/src/Franklin.jl:1
 [4] top-level scope at /home/runner/.julia/packages/Franklin/xhxut/src/Franklin.jl:195
 [5] include(::Module, ::String) at ./Base.jl:377
 [6] top-level scope at none:2
 [7] eval at ./boot.jl:[331](https://github.com/JuliaHealth/juliahealth.github.io/actions/runs/5941161601/job/16111528130#step:10:332) [inlined]
 [8] eval(::Expr) at ./client.jl:449
 [9] top-level scope at ./none:3
in expression starting at /home/runner/.julia/packages/Franklin/xhxut/src/eval/codeblock.jl:84
in expression starting at /home/runner/.julia/packages/Franklin/xhxut/src/Franklin.jl:195
ERROR: Failed to precompile Franklin [713c75ef-9fc9-4b05-94a9-213340da978e] to /home/runner/.julia/compiled/v1.4/Franklin/04j2g_aDJTS.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1272
 [3] _require(::Base.PkgId) at ./loading.jl:1029
 [4] require(::Base.PkgId) at ./loading.jl:927
 [5] require(::Module, ::Symbol) at ./loading.jl:922
Error: Process completed with exit code 1.
##[debug]Finishing: Build site with Franklin.jl

Any thoughts about what might be going awry here @tlienart ?

[tlienart]

Is there a reason why you guys are using a 1.4 Julia install in that deploy script? if you change that to 1, things will work;
there's definitely been a non-ideal (definitely non semver) change on Franklin's side to require a (I think 1.6) newer syntax where keywords are implicit (I think the issue here is something like abc = "hello"; foo(; abc) instead of foo(; abc=abc) but I'm not certain, didn't have the time just yet to dig).

What I am certain of is that if you upgrade your deploy script, the deployment will work because I just did it here: https://github.com/tlienart/juliahealth.github.io/actions/runs/5956300474/job/16156764977 with this deploy script: https://github.com/tlienart/juliahealth.github.io/blob/dev/.github/workflows/deploy.yml (and removing the cap on Franklin)

thanks for flagging this!

[TheCedarPrince]

Yup! That fixed the problem @tlienart ! Thanks for the suggestion!