Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notify): optimze display for messages #2159

Merged
merged 1 commit into from
Nov 11, 2022
Merged

feat(notify): optimze display for messages #2159

merged 1 commit into from
Nov 11, 2022

Conversation

willzgli
Copy link
Collaborator

@willzgli willzgli commented Nov 9, 2022

  1. change message name to support display messages by creationtimestamp in descending order
  2. add alert status in message

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@willzgli willzgli requested a review from choujimmy as a code owner November 9, 2022 03:55
pkg/notify/apiserver/handler.go Outdated Show resolved Hide resolved
@willzgli willzgli requested review from huxiaoliang and removed request for choujimmy November 9, 2022 07:44
1. change message name to support display messages by creationtimestamp in descending order
2. add alert status in message
3. display more columns for message
@leoryu leoryu merged commit 0602f2b into tkestack:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants