Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing zerocopy dependency #180

Closed
a1phyr opened this issue Oct 25, 2023 · 3 comments
Closed

Consider removing zerocopy dependency #180

a1phyr opened this issue Oct 25, 2023 · 3 comments

Comments

@a1phyr
Copy link
Contributor

a1phyr commented Oct 25, 2023

Hi!

#162 added zerocopy dependency, which in turn brings zerocopy_derive, which brings all the proc-macro dependency. This pushes ahash very far in the compilation chain, which is damageable for such a fundamental crate.

Are you willing to revert #162, or at least to consider a cheaper alternative ?

@tkaitchuck
Copy link
Owner

tkaitchuck commented Oct 26, 2023

Can you quantify this? From my POV,
If I just run cargo build in a clean working directory for ahash it's only building 7 things and takes about 1 sec.

@SchrodingerZhu
Copy link

@a1phyr zerocopy_derive is gated by a flag and it is not effective in ahash.

@a1phyr
Copy link
Contributor Author

a1phyr commented Nov 22, 2023

I found out that it appeared in my Cargo.lock due to the proc-macro version trick (depending on the proc-macro with a cfg(any()) target).

If no other dependency activates the feature this is fine I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants