Skip to content

Add inference tests on inverse_transform #1119

Closed
Mr-Geekman opened this issue Feb 16, 2023 · 1 comment
Closed

Add inference tests on inverse_transform #1119

Mr-Geekman opened this issue Feb 16, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

🚀 Feature Request

In #1094 we added tests for transform method. We also want to add similar tests for inverse_transform.

Proposal

  1. TestInverseTransformTrainSubsetSegments
    Do transform + inverse_transform on all segments, on subset of segments and compare them.
  2. TestInverseTransformFutureSubsetSegments
    Same
  3. TestInverseTransformTrainNewSegments
    Check that inverse_transform generates expected columns:
    • Expected columns are removed.
    • Expected columns are added.
    • Expected columns are revert to original values.
    • No other changes are made.
  4. TestInverseTransformFutureNewSegments
    Same
  5. TestTransformFutureWithTarget
    Same
  6. TestTransformFutureWithoutTarget
    Same

Test cases

Look at Proposal.

Additional context

No response

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Feb 16, 2023
@Mr-Geekman Mr-Geekman added this to the Inference 2.1 milestone Feb 16, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Feb 16, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Feb 20, 2023
@Mr-Geekman Mr-Geekman self-assigned this Feb 20, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 20, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Feb 22, 2023
@Mr-Geekman
Copy link
Contributor Author

Closed by #1127.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant