Skip to content

[BUG] Fix SegmentEncoderTransform to pass inference tests #1100

Closed
1 task done
Mr-Geekman opened this issue Feb 7, 2023 · 1 comment
Closed
1 task done

[BUG] Fix SegmentEncoderTransform to pass inference tests #1100

Mr-Geekman opened this issue Feb 7, 2023 · 1 comment
Assignees
@Mr-Geekman
Labels
bug Something isn't working
Milestone
Inference 2.1

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Feb 7, 2023 •
edited
Loading

🐛 Bug Report

According to #1094, SegmentEncoderTransform has problems with working on subset of segments and given uncomprehensive error if new segments are met.

Expected behavior

  • SegmentEncoderTransform works fine on subset of segments.
  • SegmentEncoderTransform gives understandable error message if new segments are met.

To make this we should avoid using self._le.classes_ and use segments present in df instead.

How To Reproduce

Run #1094.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label Feb 7, 2023
@Mr-Geekman Mr-Geekman added this to the Inference 2.1 milestone Feb 7, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman self-assigned this Feb 7, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to Specification in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman changed the title [BUG] Teach SegmentEncoderTransform to pass inference tests [BUG] Fix SegmentEncoderTransform to pass inference tests Feb 7, 2023
@Mr-Geekman Mr-Geekman removed their assignment Feb 7, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman self-assigned this Feb 7, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 7, 2023
@Mr-Geekman Mr-Geekman mentioned this issue Feb 7, 2023
Merged
4 tasks
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Feb 7, 2023
@Mr-Geekman
Copy link
Contributor Author

Closed by #1103.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mr-Geekman Mr-Geekman

Labels
bug Something isn't working
Projects
etna board
Status: Done
Milestone
Inference 2.1
Development

No branches or pull requests
1 participant
@Mr-Geekman