Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement convenience traits #6

Closed
MattesWhite opened this issue Apr 6, 2021 · 1 comment
Closed

Implement convenience traits #6

MattesWhite opened this issue Apr 6, 2021 · 1 comment

Comments

@MattesWhite
Copy link
Contributor

First of all thank you for this crate. It works well and suits my use-case.

However, the handling is a little bit inconvenient. All conversions are done via From and TryFrom or new() constructors. As a result, I had to reference the docs a lot while programming.

Accordingly, I suggest to implement the usual convenience traits to improve the usability of iref, e.g. FromStr, ToOwned and AsRef.

I read that you want to wait for custom DSTs to land. However, the latest comments mentioned that the feature is not part of the 2021 roadmap. So I think its save to assume that the feature won't land for quite some time.

If you agree I would be glad to write a PR. I have a couple of more ideas to improve usability, e.g. using rustfmt and clippy, but for now that's enough.

@timothee-haudebourg
Copy link
Owner

Hi,

Thanks for the feedback. That seems like some good ideas, I'll be glad to take a look at your PR 😄

I read that you want to wait for custom DSTs to land

That's right, but that will be for a next major release, nothing stops us from improving this version without it.

using rustfmt and clippy

I don't mind, but I would prefer having those in a separate PR. The only condition I have is keeping the hard tabs for accessibility purposes by putting a .rustfmt.toml file with hard_tabs = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants