Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

Test failure #20

Closed
IainNZ opened this issue May 11, 2014 · 2 comments
Closed

Test failure #20

IainNZ opened this issue May 11, 2014 · 2 comments

Comments

@IainNZ
Copy link

IainNZ commented May 11, 2014

Seems to be floating point error
http://iainnz.github.io/packages.julialang.org/?pkg=Grid&ver=0.3

@timholy
Copy link
Owner

timholy commented May 11, 2014

Thanks for letting me know. As you probably guessed, the tests uses random numbers, and this was an intermittent failure (most of the time it passes). It was having the hardest time when the value of the Hessian was very small. So I changed the criterion to use an absolute, rather than relative, cutoff. It passed the test 100 times in a row for me, so hopefully this should fix it. New version pushed and tagged; let's see what happens tomorrow.

@timholy
Copy link
Owner

timholy commented May 11, 2014

Fixed by 9c85db4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants