Reduce Postgres logs noise on regression tests #7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7043 +/- ##
==========================================
+ Coverage 80.06% 82.20% +2.13%
==========================================
Files 190 217 +27
Lines 37181 38854 +1673
Branches 9450 10014 +564
==========================================
+ Hits 29770 31939 +2169
+ Misses 2997 2931 -66
+ Partials 4414 3984 -430 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
4 times, most recently
from
1ae9d0f to
c711dea
Compare
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
c711dea to
56f882e
Compare
akuzm
approved these changes
Jul 31, 2024
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
56f882e to
4cae7e5
Compare
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
4cae7e5 to
a601348
Compare
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
a601348 to
6c55fcd
Compare
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
6c55fcd to
2b385d5
Compare
mkindahl
reviewed
Oct 7, 2024
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
3 times, most recently
from
1f9fedf to
68a9e9f
Compare
For each regression database created we execute the test/sql/utils/testsupport.sql to setup some test stuff before actually run the tests. Once we config Postgres to emit log for all executed statements we create a log of noise on logs about this setup SQL script. Change it to run the setup SQL script on the `template1` database so all new created databases will contain all the necessary objects for run the tests.
fabriziomello
force-pushed
the
reduce_postgres_logs_noise_on_regression_tests
branch
from
68a9e9f to
6772cc6
Compare
mkindahl
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each regression database created we execute the
test/sql/utils/testsupport.sqlto setup some test stuff before actually run the tests. Once we config Postgres to emit log for all executed statements we create a log of noise on logs about this setup SQL script.Change it to run the setup SQL script on the
template1database so all new created databases will contain all the necessary objects for run the tests.Disable-check: force-changelog-file