-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to tower-grpc #3951
Comments
This is a great idea! Hope @carllerche can help us :-) If we really want to do this, at first, I guess we need to do a benchmark comparing the C gRPC and tower gRPC. |
To add tower-rs to TiKV, we may:
For 3 and 4, maybe the most problem for us is how to handle two different protobuf libraries, now we heavily depend on rust-protobuf, but tower uses prost, migrating to prost will change lots of code and take a long time. |
@ice1000 I've unassigned myself since I don't think I'll be involved in this. |
I think at first we can migrate rust-protobuf to prost, then we can try tower-grpc easily. |
The gRPC stack tikv is on is unloved and it looks like the future of gRPC in Rust is https://github.com/tower-rs/tower-grpc. Let's start migrating in that direction.
There will be many unknowns here, upstream contributions needed, benchmarking, careful regression testing.
The text was updated successfully, but these errors were encountered: