Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region Scatter supports the learner peer #2485

Closed
nolouch opened this issue Jun 1, 2020 · 2 comments · Fixed by #2531
Closed

Region Scatter supports the learner peer #2485

nolouch opened this issue Jun 1, 2020 · 2 comments · Fixed by #2531
Labels
component/schedule Scheduling logic. epic/co-attributes relative data attributes. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@nolouch
Copy link
Contributor

nolouch commented Jun 1, 2020

Feature Request

Describe your feature request related problem:

some user may use tiflash + tikv, and use pre-split to pre -balance the regions.
because the region scatters only consider voters, so let the learner peer may not under the balance, which causes some tiflashes IO became very busy.

Describe the feature you'd like:

region scatter can consider the learner and the label of the engine.
@nolouch nolouch added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 1, 2020
@rleungx rleungx mentioned this issue Jun 2, 2020
Closed
@rleungx rleungx added the component/schedule Scheduling logic. label Jun 2, 2020
@sticnarf
Copy link
Contributor

sticnarf commented Jun 4, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 4, 2020

Dear contributor, the second Performance challenge program has been closed. But you can still contribute to this issue and we appreciate your contribution.

@nolouch nolouch added the epic/co-attributes relative data attributes. label Jun 8, 2020
@sticnarf sticnarf mentioned this issue Jun 11, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/schedule Scheduling logic. epic/co-attributes relative data attributes. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schedule: scatter regions to stores with the same engine sticnarf/pd
4 participants
@nolouch @sticnarf @sre-bot @rleungx