From 7187a7ab72dbbc90eb24ab82e4eab1e134064da4 Mon Sep 17 00:00:00 2001 From: Ryan Leung Date: Mon, 25 Jul 2022 13:59:10 +0800 Subject: [PATCH] *: clean up the leak options (#5336) ref tikv/pd#4813 Signed-off-by: Ryan Leung Co-authored-by: Ti Chi Robot --- pkg/testutil/leak.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/pkg/testutil/leak.go b/pkg/testutil/leak.go index 2750109e551..d1329aef0e6 100644 --- a/pkg/testutil/leak.go +++ b/pkg/testutil/leak.go @@ -19,22 +19,13 @@ import "go.uber.org/goleak" // LeakOptions is used to filter the goroutines. var LeakOptions = []goleak.Option{ goleak.IgnoreTopFunction("github.com/syndtr/goleveldb/leveldb.(*DB).mpoolDrain"), - goleak.IgnoreTopFunction("github.com/syndtr/goleveldb/leveldb.(*DB).tCompaction"), - goleak.IgnoreTopFunction("github.com/syndtr/goleveldb/leveldb/util.(*BufferPool).drain"), - goleak.IgnoreTopFunction("github.com/syndtr/goleveldb/leveldb.(*DB).mCompaction"), - goleak.IgnoreTopFunction("github.com/syndtr/goleveldb/leveldb.(*DB).compactionError"), goleak.IgnoreTopFunction("google.golang.org/grpc.(*ccBalancerWrapper).watcher"), - goleak.IgnoreTopFunction("google.golang.org/grpc.(*ccResolverWrapper).watcher"), - goleak.IgnoreTopFunction("google.golang.org/grpc.(*addrConn).createTransport"), goleak.IgnoreTopFunction("google.golang.org/grpc.(*addrConn).resetTransport"), - goleak.IgnoreTopFunction("google.golang.org/grpc.(*Server).handleRawConn"), goleak.IgnoreTopFunction("go.etcd.io/etcd/pkg/logutil.(*MergeLogger).outputLoop"), goleak.IgnoreTopFunction("sync.runtime_notifyListWait"), // TODO: remove the below options once we fixed the http connection leak problems goleak.IgnoreTopFunction("internal/poll.runtime_pollWait"), goleak.IgnoreTopFunction("net/http.(*persistConn).writeLoop"), - goleak.IgnoreTopFunction("net/http.(*persistConn).readLoop"), - goleak.IgnoreTopFunction("runtime.goparkunlock"), // natefinch/lumberjack#56, It's a goroutine leak bug. Another ignore option PR https://github.com/pingcap/tidb/pull/27405/ goleak.IgnoreTopFunction("gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"), }