-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix flake check fails on Ghaf mainline #296
Comments
#293 is merged already, but I agree we should start introducing checks such as this to GitHub actions. |
Currently (ghaf HEAD at b0bfc8f), nix flake check can not be added as pre-merge check because One can ignore the IFD error with the option
The above issue was supposed to be fixed with NixOS/nix#7759. However, the issue still remains valid for IFD flakes: NixOS/nix#4265. For now, this issue is blocking the usage of One possible solution would be to get rid of the IFD in ghaf flake. At least one source of IFD is the packaging of ssh keys in waypipe-ssh, but there might be others too. |
I'm wondering could it be possible to improve by getting rid of all IFDs and implementing stuff in a different way? |
Technically, it can be run with |
|
When checking the ghaf flake with
nix flake check --all-systems
I get the following:Background: In Nix, the act of "importing from a derivation" allows for the dynamic generation of Nix expressions during the build process. By default, the allow-import-from-derivation option is disabled because IFD can have potential complications when used with Hydra, Nix's CI server.
Maybe we could also add the flake check into Github Actions CI maybe as part of #293
The text was updated successfully, but these errors were encountered: