parse_guess doesn't ignore NA values, thus rendering the na parameter less useful.

[jmarshallnz]

I'd expect that parse_guess would first remove NA strings prior to guessing the type. Otherwise anything with an NA encoded as a string (rather than _NA_character) would not be guessed correctly, as guess_parser does not filter NA strings.

---

> parse_guess(c("123", NA))
[1] 123  NA
> parse_guess(c("123", "NA"), na="NA")
[1] "123" NA  

Notice that it is converting the "NA" to NA, but not prior to parsing.

[jmarshallnz]

Nice! I was about to dive into the code today but you beat me to it. Thanks very much! :)

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/