-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why can't you exactly divide a year-long interval by days? #445
Comments
I think this is a poorly written attempt to warn people away from
Perhaps the message should just say something like, "Performing %/%; convert denominator to an interval or duration if you want a remainder." |
I actually started removing those messages here and there. It's more annoying than helpful. The approximate computation with periods is stated in the docs in multiple places, so people who use those should be already aware of pitfalls. |
Given that for a bulk of arithmetic operations with shorter periods is exact and that we currently use surpressWarnings to hide these warnings in a bunch of places, maintaining these warnings appears wrong to me. So, unless you object I am removing them and adding methods for some arithmetic operations with periods which currently throw errors. |
Yeah, I think it's a reasonable change. |
I think the warning "convert periods to intervals for accuracy" is also spurious. What period am I supposed to convert?
The text was updated successfully, but these errors were encountered: