ggmosaic::geom_mosaic breaks with version 3.3.0

[rmcd1024]

Axis tick marks and tick-mark labels appear with ggplot2 3.2.1 but not with ggplot2 3.3.0. Examples below created using ggomosaic 0.2.2, but this happened also with 0.2.0.

library(ggplot2 )  ## 3.2.1
library(ggmosaic)  ## 0.2.2 (dev version)
ggplot(data = titanic) + geom_mosaic(aes(x = product(Class), fill = Survived))

library(ggplot2 )  ## 3.3.0
library(ggmosaic)  ## 0.2.2 (dev version)
ggplot(data = titanic) + geom_mosaic(aes(x = product(Class), fill = Survived))

[clauswilke]

I suspect this is a problem with the ggmosaic code. From looking at geom_mosaic(), I see a lot of strange manipulations of the aesthetic mapping. I wonder whether this code made assumptions about how mappings are stored internally in ggplot2 that aren't true anymore.

https://github.com/haleyjeppson/ggmosaic/blob/master/R/geom-mosaic.r

Maybe @yutannihilation has more insight here.

[yutannihilation]

Not sure whether the tweaks ggmosaic adds are valid or not, but probably this is due to the change around axis guide (e.g. #3398).

[clauswilke]

Yeah, I was wondering about this.

@paleolimbot If you've got free time, would you be able to look into this and maybe suggest a fix to the ggmosaic authors?

[paleolimbot]

Of course! I'll give it a shot this evening.

[paleolimbot]

This is an issue with the scale_(x|y)_productlist() in ggmosaic...a position scale subclasss that I didn't know about. I've updated the issue in ggmosaic and offered to PR a fix!

[yutannihilation]

Wow, so quick! Thanks @paleolimbot and @rmcd1024. I added a minor comment on your PR, but maybe you can ignore.

haleyjeppson/ggmosaic#42