From 040f316900c247d8a31bdade0d087633859dbbab Mon Sep 17 00:00:00 2001 From: Emil Hvitfeldt Date: Tue, 21 Jan 2025 15:51:12 -0800 Subject: [PATCH] change minimum `min_unique()` for `step_discretize()` to 1 --- R/discretize.R | 2 +- tests/testthat/_snaps/discretize.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/R/discretize.R b/R/discretize.R index d395ddacb..eca01ef7b 100644 --- a/R/discretize.R +++ b/R/discretize.R @@ -346,7 +346,7 @@ prep.step_discretize <- function(x, training, info = NULL, ...) { col_names <- recipes_eval_select(x$terms, training, info) check_type(training[, col_names], types = c("double", "integer")) check_number_whole(x$num_breaks, min = 1, arg = "num_breaks") - check_number_whole(x$min_unique, min = 2, arg = "min_unique") + check_number_whole(x$min_unique, min = 1, arg = "min_unique") if (length(col_names) > 1 & any(names(x$options) %in% c("prefix", "labels"))) { cli::cli_warn( diff --git a/tests/testthat/_snaps/discretize.md b/tests/testthat/_snaps/discretize.md index 55cf46804..537b6a22a 100644 --- a/tests/testthat/_snaps/discretize.md +++ b/tests/testthat/_snaps/discretize.md @@ -137,7 +137,7 @@ Condition Error in `step_discretize()`: Caused by error in `prep()`: - ! `min_unique` must be a whole number larger than or equal to 2, not the number -1. + ! `min_unique` must be a whole number larger than or equal to 1, not the number -1. # war when less breaks are generated