P1-[4.0 bug hunting]-[Dashboard + TiFlash]-Disk info collector in TiFlash is incorrect

[YKG]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

• deploy a cluster on Azure with tiup cluster
• visit dashboard -- cluster diagnose
• start a diagnose job
• view full report
• check Cluster Hardware database table

2. What did you expect to see?

• The DISK(GB) column of TiFlash in the report should be the same with PD's since this two VMs have the same configration
• TiFlash disk info in Cluster Hardware database table should be also the same with PD's

3. What did you see instead?

• in the report, TiFlash disk column is empty

  

• in the Cluster Hardware database table, TiFlash has a row count 1 when total filter is applied, but PD has 3.

  

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

v4.0.0-rc.2

Additional notes

A deploy on Tencent Cloud has the same problem.

[gengliqi]

@breeswish PTAL

[breezewish]

@leiysky

[leiysky]

I'll fix it.

Would you please provide /proc/mounts in the VM?

[YKG]

• Azure

ykg@sgp:~$ cat /proc/mounts
sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
udev /dev devtmpfs rw,nosuid,relatime,size=1977564k,nr_inodes=494391,mode=755 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
tmpfs /run tmpfs rw,nosuid,noexec,relatime,size=401868k,mode=755 0 0
/dev/sda1 / ext4 rw,relatime,discard 0 0
securityfs /sys/kernel/security securityfs rw,nosuid,nodev,noexec,relatime 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
tmpfs /run/lock tmpfs rw,nosuid,nodev,noexec,relatime,size=5120k 0 0
tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,mode=755 0 0
cgroup /sys/fs/cgroup/unified cgroup2 rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/systemd cgroup rw,nosuid,nodev,noexec,relatime,xattr,name=systemd 0 0
pstore /sys/fs/pstore pstore rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0
cgroup /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
cgroup /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0
cgroup /sys/fs/cgroup/net_cls,net_prio cgroup rw,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
cgroup /sys/fs/cgroup/perf_event cgroup rw,nosuid,nodev,noexec,relatime,perf_event 0 0
cgroup /sys/fs/cgroup/cpu,cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
cgroup /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0
cgroup /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
systemd-1 /proc/sys/fs/binfmt_misc autofs rw,relatime,fd=26,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=14419 0 0
mqueue /dev/mqueue mqueue rw,relatime 0 0
hugetlbfs /dev/hugepages hugetlbfs rw,relatime,pagesize=2M 0 0
debugfs /sys/kernel/debug debugfs rw,relatime 0 0
configfs /sys/kernel/config configfs rw,relatime 0 0
/dev/sda15 /boot/efi vfat rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=ascii,shortname=mixed,utf8,errors=remount-ro,discard 0 0
/dev/sdb1 /mnt ext4 rw,relatime 0 0
lxcfs /var/lib/lxcfs fuse.lxcfs rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other 0 0
fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0
tmpfs /run/user/1000 tmpfs rw,nosuid,nodev,relatime,size=401864k,mode=700,uid=1000,gid=1000 0 0
binfmt_misc /proc/sys/fs/binfmt_misc binfmt_misc rw,relatime 0 0
overlay /var/lib/docker/overlay2/027d64e6957bc8ffe2ab5008f81e5aa6cf1dfbc5c1b070b853beb3f52adec571/merged overlay rw,relatime,lowerdir=/var/lib/docker/overlay2/l/2JSLYYHZDZ6SR3KIJ3ID36JNLT:/var/lib/docker/overlay2/l/V67NKYBUJ57JD2FCXZOXDW3HOR:/var/lib/docker/overlay2/l/GA3WV7QUTJL3P6OZD7EWRAUNXR:/var/lib/docker/overlay2/l/T34SYY7XGSJH75T5WLYUEKEWPW,upperdir=/var/lib/docker/overlay2/027d64e6957bc8ffe2ab5008f81e5aa6cf1dfbc5c1b070b853beb3f52adec571/diff,workdir=/var/lib/docker/overlay2/027d64e6957bc8ffe2ab5008f81e5aa6cf1dfbc5c1b070b853beb3f52adec571/work 0 0
shm /var/lib/docker/containers/84bee7bf6bc079f93827e56e47249562c22077d746d1f08506f41e0c3be78982/mounts/shm tmpfs rw,nosuid,nodev,noexec,relatime,size=65536k 0 0
nsfs /run/docker/netns/3c629dd9bfcc nsfs rw 0 0
tracefs /sys/kernel/debug/tracing tracefs rw,relatime 0 0
ykg@sgp:~$

• Tencent Cloud

ubuntu@VM-0-9-ubuntu:~$ cat /proc/mounts
sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
udev /dev devtmpfs rw,nosuid,relatime,size=1907424k,nr_inodes=476856,mode=755 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
tmpfs /run tmpfs rw,nosuid,noexec,relatime,size=387808k,mode=755 0 0
/dev/vda1 / ext4 rw,relatime,errors=remount-ro 0 0
securityfs /sys/kernel/security securityfs rw,nosuid,nodev,noexec,relatime 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
tmpfs /run/lock tmpfs rw,nosuid,nodev,noexec,relatime,size=5120k 0 0
tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,mode=755 0 0
cgroup /sys/fs/cgroup/unified cgroup2 rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/systemd cgroup rw,nosuid,nodev,noexec,relatime,xattr,name=systemd 0 0
pstore /sys/fs/pstore pstore rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0
cgroup /sys/fs/cgroup/cpu,cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
cgroup /sys/fs/cgroup/perf_event cgroup rw,nosuid,nodev,noexec,relatime,perf_event 0 0
cgroup /sys/fs/cgroup/net_cls,net_prio cgroup rw,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
cgroup /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0
cgroup /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
cgroup /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0
cgroup /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
hugetlbfs /dev/hugepages hugetlbfs rw,relatime,pagesize=2M 0 0
debugfs /sys/kernel/debug debugfs rw,relatime 0 0
mqueue /dev/mqueue mqueue rw,relatime 0 0
systemd-1 /proc/sys/fs/binfmt_misc autofs rw,relatime,fd=43,pgrp=1,timeout=0,minproto=5,maxproto=5,direct,pipe_ino=13104 0 0
configfs /sys/kernel/config configfs rw,relatime 0 0
lxcfs /var/lib/lxcfs fuse.lxcfs rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other 0 0
fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0
tmpfs /run/user/500 tmpfs rw,nosuid,nodev,relatime,size=387808k,mode=700,uid=500,gid=500 0 0
ubuntu@VM-0-9-ubuntu:~$

[breezewish]

BTW I believe that only displaying one disk in TiFlash is intended behaviour for now, right? @leiysky

[leiysky]

@breeswish Yes. The displaying one will match TiFlash's deploy path.

[breezewish]

@crazycs520 So now we only have one problem remains, the info is not correctly displayed in the diagnostics report.

[shuke987]

/bug P1

[leiysky]

@breeswish I think this issue has been fixed by a PR that belongs to a private repo.

[breezewish]

@leiysky Cool. Is this fix released?