Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guzzlehttp/psr7 version 2.x as composer dependency #4

Open
maecompany opened this issue Sep 15, 2022 · 2 comments
Open

Allow guzzlehttp/psr7 version 2.x as composer dependency #4

maecompany opened this issue Sep 15, 2022 · 2 comments

Comments

@maecompany
Copy link

maecompany commented Sep 15, 2022

Currently "guzzlehttp/psr7" is locked to the ^1.4 version range in composer.json.

This is blocking us from upgrading our stack, because several other dependencies (for example codeception/module-rest) now require guzzlehttp/psr7 versions 2.x and up.

Would it be possible to add support for the 2.x range by changing "guzzlehttp/psr7": "^1.4" to "guzzlehttp/psr7": "^1.4 || ^2.0"?

The only change needed is updating this line to:
$queryParams = \GuzzleHttp\Psr7\Query::parse($request->getUri()->getQuery());

@her-ur
Copy link

her-ur commented Nov 28, 2022

Hi @mbonneau, we would also appreciate to do this update, because dependencies update. Here is MR: #5
Thank you very much!

@zarv1k
Copy link

zarv1k commented Oct 22, 2024

I'm using PHP 8.2 and there is deprecation warning like the following in guzzlehttp/psr7 1.7:

Deprecated: Creation of dynamic property GuzzleHttp\Psr7\CachingStream::$stream is deprecated

It's already fixed in guzzlehttp/psr7 since 2.4.0, but I can't update guzzlehttp/psr7 to 2.x, coz thruway/ratchet-transport locked with "guzzlehttp/psr7": "^1.4"
So would be really great if the thruway/ratchet-transport supported guzzlehttp/psr7 2.x.

@mbonneau could you please review merge the #5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants