From 6cddeb04a0265dd95bec6b2b3ff485cb5c4962fa Mon Sep 17 00:00:00 2001 From: Samuel Rigaud <46346622+s-rigaud@users.noreply.github.com> Date: Fri, 17 May 2024 03:17:56 +0000 Subject: [PATCH 1/2] Add TransformControlMode and add missing event mode --- .../examples/jsm/controls/TransformControls.d.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/types/three/examples/jsm/controls/TransformControls.d.ts b/types/three/examples/jsm/controls/TransformControls.d.ts index 802253429..e9a63111b 100644 --- a/types/three/examples/jsm/controls/TransformControls.d.ts +++ b/types/three/examples/jsm/controls/TransformControls.d.ts @@ -1,9 +1,11 @@ import { Camera, Mesh, MOUSE, Object3D, Object3DEventMap, Quaternion, Raycaster, Vector3 } from "three"; +type TransformControlMode = "translate" | "rotate" | "scale"; + export interface TransformControlsEventMap extends Object3DEventMap { change: {}; - mouseDown: {}; - mouseUp: {}; + mouseDown: { mode: TransformControlMode }; + mouseUp: { mode: TransformControlMode }; objectChange: {}; "camera-changed": { value: unknown }; "object-changed": { value: unknown }; @@ -43,7 +45,7 @@ export class TransformControls extends Object3D { object: Object3D | undefined; enabled: boolean; axis: "X" | "Y" | "Z" | "E" | "XY" | "YZ" | "XZ" | "XYZ" | "XYZE" | null; - mode: "translate" | "rotate" | "scale"; + mode: TransformControlMode; translationSnap: number | null; rotationSnap: number | null; space: "world" | "local"; @@ -67,9 +69,9 @@ export class TransformControls extends Object3D { attach(object: Object3D): this; detach(): this; - getMode(): "translate" | "rotate" | "scale"; + getMode(): TransformControlMode; getRaycaster(): Raycaster; - setMode(mode: "translate" | "rotate" | "scale"): void; + setMode(mode: TransformControlMode): void; setTranslationSnap(translationSnap: number | null): void; setRotationSnap(rotationSnap: number | null): void; setScaleSnap(scaleSnap: number | null): void; @@ -108,7 +110,7 @@ export class TransformControlsPlane extends Mesh { constructor(); - mode: "translate" | "scale" | "rotate"; + mode: TransformControlMode; axis: "X" | "Y" | "Z" | "XY" | "YZ" | "XZ" | "XYZ" | "E"; From e0db683af232660ab5bed84c4397a209c5561beb Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Fri, 17 May 2024 17:47:46 -0400 Subject: [PATCH 2/2] Rename --- .../examples/jsm/controls/TransformControls.d.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/types/three/examples/jsm/controls/TransformControls.d.ts b/types/three/examples/jsm/controls/TransformControls.d.ts index e9a63111b..adf7757ac 100644 --- a/types/three/examples/jsm/controls/TransformControls.d.ts +++ b/types/three/examples/jsm/controls/TransformControls.d.ts @@ -1,11 +1,11 @@ import { Camera, Mesh, MOUSE, Object3D, Object3DEventMap, Quaternion, Raycaster, Vector3 } from "three"; -type TransformControlMode = "translate" | "rotate" | "scale"; +type TransformControlsMode = "translate" | "rotate" | "scale"; export interface TransformControlsEventMap extends Object3DEventMap { change: {}; - mouseDown: { mode: TransformControlMode }; - mouseUp: { mode: TransformControlMode }; + mouseDown: { mode: TransformControlsMode }; + mouseUp: { mode: TransformControlsMode }; objectChange: {}; "camera-changed": { value: unknown }; "object-changed": { value: unknown }; @@ -45,7 +45,7 @@ export class TransformControls extends Object3D { object: Object3D | undefined; enabled: boolean; axis: "X" | "Y" | "Z" | "E" | "XY" | "YZ" | "XZ" | "XYZ" | "XYZE" | null; - mode: TransformControlMode; + mode: TransformControlsMode; translationSnap: number | null; rotationSnap: number | null; space: "world" | "local"; @@ -69,9 +69,9 @@ export class TransformControls extends Object3D { attach(object: Object3D): this; detach(): this; - getMode(): TransformControlMode; + getMode(): TransformControlsMode; getRaycaster(): Raycaster; - setMode(mode: TransformControlMode): void; + setMode(mode: TransformControlsMode): void; setTranslationSnap(translationSnap: number | null): void; setRotationSnap(rotationSnap: number | null): void; setScaleSnap(scaleSnap: number | null): void; @@ -110,7 +110,7 @@ export class TransformControlsPlane extends Mesh { constructor(); - mode: TransformControlMode; + mode: TransformControlsMode; axis: "X" | "Y" | "Z" | "XY" | "YZ" | "XZ" | "XYZ" | "E";