From 8300606eace163895d25cb0df85f74b160513061 Mon Sep 17 00:00:00 2001 From: Arthur LAURENT Date: Fri, 13 May 2022 18:47:36 +0200 Subject: [PATCH 1/2] fix: Add missing extend to Loader in NRRDLoader --- types/three/examples/jsm/loaders/NRRDLoader.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/three/examples/jsm/loaders/NRRDLoader.d.ts b/types/three/examples/jsm/loaders/NRRDLoader.d.ts index ad28a47b3..c5978f8a4 100644 --- a/types/three/examples/jsm/loaders/NRRDLoader.d.ts +++ b/types/three/examples/jsm/loaders/NRRDLoader.d.ts @@ -1,8 +1,8 @@ -import { LoadingManager } from '../../../src/Three'; +import { Loader, LoadingManager } from '../../../src/Three'; import { Volume } from '../misc/Volume'; -export class NRRDLoader { +export class NRRDLoader extends Loader { constructor(manager?: LoadingManager); manager: LoadingManager; path: string; From 382fc075d7f53bb5f90795d0a83bb1772fde95dc Mon Sep 17 00:00:00 2001 From: Arthur LAURENT Date: Fri, 13 May 2022 18:51:42 +0200 Subject: [PATCH 2/2] add: atulrnt to the contributors --- .all-contributorsrc | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 829fd5715..6ef126397 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -325,14 +325,23 @@ ] }, { - "login": "subhankar-trisetra", + "login": "subhankar-trisetra", "name": "Subhankar Pal", "avatar_url": "https://avatars.githubusercontent.com/u/98544661?v=4", "profile": "https://subho57.github.io", "contributions": [ "code", - ], - } + ], + }, + { + "login": "atulrnt", + "name": "Arthur LAURENT", + "avatar_url": "https://avatars.githubusercontent.com/u/894203?v=4", + "profile": "https://github.com/atulrnt", + "contributions": [ + "code", + ], + } ], "skipCi": true, "contributorsPerLine": 7