[FEATURE] Allow custom title instead file name #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the libgconf package as an addon to Travis for getting Cypress to run. Apparently travis upgraded to Ubuntu 16.4 where this package is not intrinsically included anymore. Find more about this at cypress-io/cypress#4069 Besides, the TEST_URL environment variable is added as a travis.yml directive in order to work across forks.
This introduces an opportunity to provide an optional query parameter named documentTitle which will then be used instead of the file name as title. In order to achieve this some minor refactoring is done additionally.
|
Hello @afoeder , Hope you are doing well! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an opportunity to provide an optional query
parameter named documentTitle which will then be used instead
of the file name as title.
In order to achieve this some minor refactoring is done additionally.
Besides, it adjusts a travis configuration that seems to be necessary: Travis' Ubuntu has been upgraded to 16.4 where the package libconf is not included anymore, but required by Cypress in order to run the end to end tests. That change adds libgconf to the travis config explicitly. This has been mentioned at cypress-io/cypress#4069.