Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/venv support broken #2309

Closed
afterthought opened this issue Feb 15, 2022 · 3 comments
Closed

python/venv support broken #2309

afterthought opened this issue Feb 15, 2022 · 3 comments
Labels

Comments

@afterthought
Copy link
Contributor

Ref: #2210

I'm posting this as a new issue so it's not lost on a closed PR. This is holding back plz adoption on our team.

@Tatskaari, I tested this and it doesn't quite work. Only 1 pip_library gets linked to python/venv and then the remaining ones are skipped because this line is checking if the destination exists and it does already after the first lib creates python/venv.

@afterthought
Copy link
Contributor Author

I've started looking at this more. It might be OS specific. I'm seeing the issue on Debian. However, I tested inside the official please ubuntu image and it seems to work correctly here.

@afterthought
Copy link
Contributor Author

No one has looked at my fork yet. I'm going to create a PR I guess. Hopefully it's not too far off base.

@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had any recent activity in the past 90 days. It will be closed if no further activity occurs. If you require additional support, please reply to this message. Thank you for your contributions.

@stale stale bot added the wontfix label May 25, 2022
@stale stale bot closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant