Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) <error method of DataCollectorHook class in python-provider use a non declared variable details> #2366

Closed
tungntpham opened this issue Sep 16, 2024 · 0 comments · Fixed by #2365
Assignees
Labels
bug Something isn't working p1 High priority

Comments

@tungntpham
Copy link
Contributor

Observed behaviour

I used the sample program for python-provider without starting the relay proxy. I noticed from the log, an error is thrown in error method, saying that the details variable does not exist. From the code, I can see that it is a copy and paste of the after method which has details passed as an argument. The error method does not have this parameter as an input, so the error was thrown.
This is a syntactical error.

Expected Behavior

The problem should not throw a syntatical error.

Steps to reproduce

Run the python sample at here from the go-feature-flag doc without started a relay proxy.

The error should be able to be observed from the log.

@tungntpham tungntpham added bug Something isn't working needs-triage A priority should be added to the issue labels Sep 16, 2024
@thomaspoignant thomaspoignant added p1 High priority and removed needs-triage A priority should be added to the issue labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants