Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return warnings for file extension #8

Merged
merged 4 commits into from
Jan 8, 2014
Merged

Conversation

pezholio
Copy link
Contributor

@pezholio pezholio commented Jan 8, 2014

Needed for theodi/shared#120

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling f4ba65c on feature-detect-file-extension into 5289b3a on master.

Floppy added a commit that referenced this pull request Jan 8, 2014
@Floppy Floppy merged commit 4e2e642 into master Jan 8, 2014
@Floppy Floppy deleted the feature-detect-file-extension branch January 8, 2014 14:13
@JeniT
Copy link

JeniT commented Jan 8, 2014

I'm a bit suspect about this. I think it's reasonable to give a warning if the extension is .xls and the content type is text/csv or the extension is .csv and the content type is not text/csv (but I think that's picked up anyway). But I wouldn't go so far as to reject anything that has an extension other than .csv (or no extension?) -- that breaks the principle of opaque URLs.

@pezholio
Copy link
Contributor Author

pezholio commented Jan 8, 2014

Actually, that's a good shout. I'll improve on this and open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants