Added open_uri_redirections to allow HTTP/HTTPS transfers #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, this seems like a good idea. |
Floppy
added a commit
that referenced
this pull request
Feb 17, 2014
Added open_uri_redirections to allow HTTP/HTTPS transfers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default open-uri doesn't allow HTTP->HTTPS or HTTPS->HTTP redirects and this is causing the error reports in Data-Liberation-Front/csvlint.io#53.
Added the open_uri_redirections gem which patches open-uri and we now allow both types of redirection.
@Floppy can you think of any issues with this? (I can't as its all open data, but wanted a second opinion).