Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors for incorrect newlines #34

Merged
merged 6 commits into from
Jan 20, 2014
Merged

Conversation

pezholio
Copy link
Contributor

As per the discussion with @JeniT in the last PR, the RFC for CSVs specifically says that lines should be specified as /r/n (or CRLF as the docs state). This PR does two things:

  • Returns an error if newlines are explicitly set to anything other than /r/n
  • Returns an error if newlines are left as the default (the parser will choke in this case), and /n is detected in the row

Should be all good to go, but I'd appreciate some feedback first.

@pezholio
Copy link
Contributor Author

@JeniT - All done now! 😄

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e55ffa5 on feature-detect-newline-types into b495b5b on master.

ldodds added a commit that referenced this pull request Jan 20, 2014
@ldodds ldodds merged commit 8a366f3 into master Jan 20, 2014
@pezholio pezholio deleted the feature-detect-newline-types branch January 20, 2014 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants