Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI #163

Merged
merged 27 commits into from
Oct 20, 2015
Merged

Refactor CLI #163

merged 27 commits into from
Oct 20, 2015

Conversation

pezholio
Copy link
Contributor

Fixes #150

We're now using Thor to build the CLI element of the gem, and using Aruba for tests, so we know everything works. There's still some CSVw stuff that isn't covered, because I'm not sure what triggers it (@JeniT can you shed any light?), but this is safe to merge 👍

pezholio added 25 commits October 9, 2015 11:41
@pezholio
Bump version
bc80a94
@pezholio
Changelog
6ca8ad9
@pezholio
First pass at Thor for CLI with some simple tests
c7de0f6
@pezholio
Use Aruba with Cucumber
efb241b
@pezholio
Don't worry about dot output
5d41bd3
@pezholio
Test piped input
3eb1f8d
@pezholio
Add schema validation
69bbc05
@pezholio
Test invalid CSV
1128e54
@pezholio
Fix and test malformed schema logic
606cea7
@pezholio
Fix and test schema that 404s
5a219de
@pezholio
Refactor schema reading
1d1e73a
@pezholio
DRY error returning
ebdccbb
@pezholio
Break schema_tables logic into its own method
8a87ffc
@pezholio
Refactor read_source and add comments
c77812c
@pezholio
Break report_lines lambda into a method
9aa7dd6
@pezholio
Moar DRYing
9239b47
@pezholio
Add simple CSVw tests
a1a1b64
@pezholio
Test for non-existent files
5071705
@pezholio
Simple CSVw Table Schema test
e8c72d4
@pezholio
Test for when no file or url is specified
c3ebd25
@pezholio
We don't need this
f9b3167
@pezholio
Handle non existent schema at a filepath
2835cde
@pezholio
Don't output errors for malformed schema on CLI
aa69921
@pezholio
Return error in the right place
25d88f3
@pezholio
Test when no CSV specified, but non CSVw schema added
b48c71f
pikesley pushed a commit that referenced this pull request Oct 20, 2015
Merge pull request #163 from theodi/feature-refactor-cli
c2eb97d 
Refactor CLI
@pikesley pikesley merged commit c2eb97d into master Oct 20, 2015
@pezholio pezholio deleted the feature-refactor-cli branch October 20, 2015 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pezholio @Floppy @pikesley