Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using #blank? if unnecessary #120

Merged
merged 2 commits into from
Feb 9, 2015
Merged

Avoid using #blank? if unnecessary #120

merged 2 commits into from
Feb 9, 2015

Conversation

jpmckinney
Copy link

Rails' #blank? method is very slow compared to just checking nil? and empty?.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.91% when pulling 16aafbe on jpmckinney:speed_blank into 08ab3af on theodi:master.

pezholio added a commit that referenced this pull request Feb 9, 2015
@pezholio
Merge pull request #120 from jpmckinney/speed_blank
604ef4d 
Avoid using #blank? if unnecessary
@pezholio pezholio merged commit 604ef4d into Data-Liberation-Front:master Feb 9, 2015
@jpmckinney jpmckinney deleted the speed_blank branch February 18, 2015 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpmckinney @coveralls @pezholio