Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up #build_formats (changes its API) #103

Merged
merged 1 commit into from
Dec 17, 2014
Merged

Speed up #build_formats (changes its API) #103

merged 1 commit into from
Dec 17, 2014

Conversation

jpmckinney
Copy link

Rewrites build_formats for more speed.

  1. Stops once best match is found and skips tests that won't match
  2. Performs count directly instead of temporarily storing a value for every row
  3. Uses symbols to be nice to garbage collector

My understanding is that #build_formats is only used internally, i.e. not part of a public API.

@Floppy
Copy link
Member

Floppy commented Nov 25, 2014

Hey there - we're not getting much time on csvlint at the moment, but I'll try to find time to review and merge this (and others) this week. Thanks for the contributions!

@JeniT JeniT mentioned this pull request Dec 17, 2014
4 tasks
@Floppy
Copy link
Member

Floppy commented Dec 17, 2014

I've pulled this into our own branch so I could bring it up to date with master; I'll merge it in a separate PR.

@Floppy Floppy merged commit 73710bc into Data-Liberation-Front:master Dec 17, 2014
@jpmckinney jpmckinney deleted the speed_format branch December 17, 2014 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants