Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose optional JSON table schema fields #55

Closed
Floppy opened this issue Feb 17, 2014 · 3 comments
Closed

Expose optional JSON table schema fields #55

Floppy opened this issue Feb 17, 2014 · 3 comments

Comments

@Floppy
Copy link
Member

Floppy commented Feb 17, 2014

JSON Table Schema defines the following optional fields:

  • type
  • title
  • description
  • format

If Csvlint::Schema could expose those, I can show them in the UI.

@ldodds
Copy link
Contributor

ldodds commented Feb 17, 2014

We've added support for type but as a field within constraint which differs from the current spec. So that's in there already, although slightly differently to the JTS spec

The format keyword in JTS might end up getting deprecated too, in favour of a separate pattern and datePattern fields. We have pattern implemented.

I'm going to be working on a PR to tweak the JSON Table Schema spec to encompass those changes. Should help us align with that for now.

We should definitely add title & description for fields though.

We could also do the same at the schema level. JTS doesn't have anything at that level, but the structure could be extended without clashing. Would let people include some basic metadata. Maybe we should make a separate proposal for that. Data Package could also reference the schema via a URL (currently its only in-line).

@Floppy
Copy link
Member Author

Floppy commented Feb 18, 2014

OK, I'll back out the format and type fields in the UI - I was thinking they would be part of constraints anyway.

@ldodds
Copy link
Contributor

ldodds commented Feb 18, 2014

I think we now expose everything (datePattern) went in earlier, going to close this for now. We can file a new issue to bring in line with changes to JTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants