Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent values due to number format differences #32

Closed
ldodds opened this issue Jan 14, 2014 · 4 comments · Fixed by #77
Closed

Inconsistent values due to number format differences #32

ldodds opened this issue Jan 14, 2014 · 4 comments · Fixed by #77

Comments

@ldodds
Copy link
Contributor

ldodds commented Jan 14, 2014

This generates an inconsistent values warning:

https://raw.github.com/datasets/cpi-gb/master/data/cpi-uk-annual.csv

Its because some numbers include decimal points and some dont. The former get matched as alphanumeric (because of the full stop) the latter as numeric.

@ldodds
Copy link
Contributor Author

ldodds commented Feb 11, 2014

@pezholio any thoughts on this one?

I'm wondering whether to drop the inconsistency checks completely -- schema validation should give us some coverage of this type of issue (e.g. mixing strings/numbers).

The alternative is to improve the checking but make it more robust for some legal variations.

@JeniT
Copy link

JeniT commented Feb 11, 2014

Numbers will decimal points in them should be recognised as numeric!

@ldodds
Copy link
Contributor Author

ldodds commented Feb 18, 2014

One option for improving this is to use some of the type validation code we have now, e.g:

Try parsing the data using various formats, keep a track of which ones pass, then warn if there are outliers.

@Floppy
Copy link
Member

Floppy commented Feb 24, 2014

For theodi/shared#158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants