Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post_meta don't display normally in the latest release [solved] #209

Closed
5 of 11 tasks
dandyxu opened this issue Apr 3, 2018 · 5 comments
Closed
5 of 11 tasks

post_meta don't display normally in the latest release [solved] #209

dandyxu opened this issue Apr 3, 2018 · 5 comments

Comments

@dandyxu
Copy link

dandyxu commented Apr 3, 2018

I agree and want to create new issue


Expected behavior

When I upgrade hexo to latest 3.7.0 and download latest release version of theme-next (v6.1.0), everything is fine but all post_meta don't display normally. For example, in the post_meta area, by default, it should display "Posted on 2018-04-03".

Actual behavior

But actually it displays as "post.posted 2018-04-03". The same as in the footer: Powered -> footer.powered etc.

Steps to reproduce the behavior

  1. Install hexo-cli and initial a new hexo from scratch;
  2. Clone theme-next v6.1.0 to the themes folder;
  3. Switch theme in the hexo _config.yml file to next and hexo generate;
  4. Hexo server and you will be able to see the issue.
  • Link to demo site with this issue: N/A
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information

node: v9.3.0
npm: 5.6.0

Package dependencies Information

all default

Hexo Information

Hexo version

hexo: 3.7.0
hexo-cli: 1.1.0

Hexo Configuration

default yml file

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

all default

Other Information

https://imgur.com/a/yj3oo

@sli1989
Copy link
Collaborator

sli1989 commented Apr 4, 2018

Live demo? How about releases/tag/v6.0.6?

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2018

@sli1989 no need to reproduce this bug in other NexT versions. I think it's appear after update to Hexo v3.7.0 with use default language fixes. So, need just to reproduce this bug under this Hexo version and try to resolve this.

Possible bugs:

  • In Hexo's default config language option not setted by default, e.g. language:
  • In Hexo's default config setted language: default

Possible fixes:

  • Add warning notes to docs about setting language option in main Hexo's config
  • Create default.yml symlink on _en.yml (best variant for now)
  • Rename _en.yml file on default.yml (need to check i18n services for this)

@dandyxu can u confirm what in previous Hexo v3.6.0 this bug not detected?
Checked, not detected in previous Hexo versions.

@sli1989
Copy link
Collaborator

sli1989 commented Apr 4, 2018

Need to set language: lang in Hexo v3.7.0. Can't leave it blank.


The bug has been confirmed only in Hexo v3.7.0+

@dandyxu
Copy link
Author

dandyxu commented Apr 4, 2018

@sli1989 @ivan-nginx Thanks for your responses and helps. As you said, the issue was happened because of language settings. Previously I set language : en and now I only need to change to language : _en or rename _en.yml file to default.yml, the issue is resolved.

@ivan-nginx I tried to install Hexo v3.6.0 but everytime I can only install the latest version v3.7.0. I'm sorry that I'm new to Hexo and I couldn't find any tutorials about installing specific version of Hexo neither. So I probably can't confirm whether this bug is also appeared in Hexo v3.6.0. However, if you can direct me some tutorials, I'm very appreciated about that. Thank you.

@sli1989 Thank you very much as well for trying to figure this issue out for me.

ivan-nginx added a commit that referenced this issue Apr 4, 2018
Created `default.yml` symlink for `_en.yml` to around #209 bug for Hexo v3.7.0 version.
Older Hexo versions will choose first language in list (in our case it's `_en.yml`).
@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2018

@dandyxu @sli1989 fixed in #210 and merged into master branch.

For now u can define language as u want:

  • language: en (recommended)
  • language: default
  • language: (not defined value, by default)
  • not exists language (language: sfdgdgdf))
    — will be used en language as default.

If issue solved, close it please.

@ivan-nginx ivan-nginx changed the title post_meta don't display normally in the latest release post_meta don't display normally in the latest release [fix added] Apr 4, 2018
@dandyxu dandyxu closed this as completed Apr 4, 2018
@ivan-nginx ivan-nginx changed the title post_meta don't display normally in the latest release [fix added] post_meta don't display normally in the latest release [solved] Mar 4, 2019
@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
@ivan-nginx ivan-nginx changed the title post_meta don't display normally in the latest release [solved] post_meta don't display normally in the latest release [solved] Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants