Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head-partial #54

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Fix head-partial #54

merged 2 commits into from
Oct 21, 2020

Conversation

eval
Copy link
Contributor

@eval eval commented Oct 21, 2020

This PR fixes 2 things:

  • builds fail for a freshly generated site because head-partial is passed a url instead of the config-map
  • the head-partial contains an html-tag, resulting in a nested html-tag being generated.

Changes have been tested by changing the generated files. I failed building the bin locally.
EDIT: verified working (via firn new && firn build) using the built artifact for Mac

eval added 2 commits October 21, 2020 13:52
Fixes failing build for freshly generated site
@teesloane
Copy link
Owner

teesloane commented Oct 21, 2020

Ah, good catch. Unfortunate that I missed that in the just released 0.0.10 - will patch this into 0.0.11 today.

edit / n.b.: I will use the artifact from this build for 0.10, so the release is still usable.

@teesloane teesloane merged commit 65a3c2e into teesloane:master Oct 21, 2020
teesloane added a commit that referenced this pull request Oct 25, 2020
- mistakenly overwrote this work in a rebase. Thanks @eval
teesloane added a commit that referenced this pull request Apr 30, 2021
- mistakenly overwrote this work in a rebase. Thanks @eval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants