Fix mobile Safari styling bug for hidden file input element #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `max-width: 0` rule to default styles, to ensure the width of the hidden file input doesn't spill out, and cause a whitespace gutter.
|
@Robdel12 @lydiaguarino qualms? |
|
I haven't tested this overly-rigorously. I saw the problem on mobile Safari on iOS 9 and iOS8, but not on Android Chrome or Windows Phone IE. I was testing mainstream mobile browsers, latest versions - 1. |
|
@timiyay interesting. I'm assuming real devices? I can't reproduce on our example repo in iOS 9.1 (on device) or iOS 9 in the simulator. I think we can accept this, looks like it'll solve an issue and won't have any negative impact that I can see. 👍 |
Robdel12
added a commit
that referenced
this pull request
Nov 3, 2015
Fix mobile Safari styling bug for hidden file input element
|
@Robdel12 Thanks for the merge. Will definitely keep an eye out for any side effects this has. It might've been some interplay between the hidden file input, and some other part of our styling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
max-width: 0rule to default styles, to ensure the width of the hidden file input doesn't spill out, and cause a whitespace gutter.This fix solves issue #16.