Addition of session.notify #39
Conversation
| @@ -60,7 +60,7 @@ def __init__(self, args, env=None, silent=False, path=None, | |||
| self.path = path | |||
| self.success_codes = success_codes or [0] | |||
|
|
|||
| def run(self, path_override=None, env_fallback=None): | |||
| def run(self, path_override=None, env_fallback=None, **kwargs): | |||
There was a problem hiding this comment.
why add kwargs and not use them?
There was a problem hiding this comment.
The invocation of Command is now sending an additional argument, which is used by NotifyCommand.__call__. This means I do not have to have a separate if check for every command subclass (there could eventually be more).
| @@ -164,6 +164,37 @@ def make_session(self, name, func): | |||
| def next(self): | |||
| return self.__next__() | |||
|
|
|||
| def notify(self, session): | |||
There was a problem hiding this comment.
How does this work with parametrized sessions?
There was a problem hiding this comment.
You can specify either the name or the parameterized name:
So both of these would work:
notify('unit_tests')notify("unit_tests(python_version='3.6')")
There was a problem hiding this comment.
It would be nice t be able to do notify(unit_test, python_version='3.6')
There was a problem hiding this comment.
It would have to be notify('unit_tests', python_version='3.6'). I agree that would be nice but assert it can be separate. (Both forms can work.)
There was a problem hiding this comment.
Do you want to add this in a follow-up PR? If so, LGTM.
This adds the
session.notifycommand, exemplified in nox's ownnox.pymodule, where any of the four interpreters trigger thecoversession.