fix: intrarelayer testnet bugs #169

fedekunze · 2021-12-12T01:12:07Z

This PR fixes 3 bugs:

supply of the coin denomination for the RegisterCoinProposal is not checked, allowing users to register an invalid token pair and mint an ERC20 if the proposal passes (see prop 52)
additional token denom units are not sanitized, preventing ERC20 tokens that contain spaces in their name to be registered
metadata validation error when registering an ERC20 with 0 decimals

* release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <[email protected]>

* Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 5061449) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Prajjwol Gautam <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>

… (#155) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <[email protected]> (cherry picked from commit 7603acd) Co-authored-by: Emmanuel T Odeke <[email protected]>

* docs(evmos): update latest version to v0.4.0 (#139) * docs: change `ethermintd` -> `evmosd` (#142) * docs: migrate cosmovisor and genesis validator instructions (#141) * docs(evmos): Add upgrade node with cosmovisor instructions * docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade * Apply suggestions from code review * go mod tidy Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * build: added build-reproducible to Makefile (#143) * release: v0.4.0 changelog (#138) * release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <[email protected]> * (build): added build-reproducible to makefile Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * docs: Add link to consensus problems if you don't upgrade your node (#146) Co-authored-by: Federico Kunze Küllmer <[email protected]> * deps: bump SDK version (#147) * deps: bump SDK version * norace * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: mergify changes (#152) * Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <[email protected]> * app: fix typo in calculation of failed transactions in TPS value (#149) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <[email protected]> * Update .goreleaser.yml (#156) Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Rohit Durvasula <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Prajjwol Gautam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <[email protected]>

* docs(evmos): update latest version to v0.4.0 (#139) * docs: change `ethermintd` -> `evmosd` (#142) * docs: migrate cosmovisor and genesis validator instructions (#141) * docs(evmos): Add upgrade node with cosmovisor instructions * docs(evmos): Add Incorporate changes from Cosmos Hub Vega Upgrade * Apply suggestions from code review * go mod tidy Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * build: added build-reproducible to Makefile (#143) * release: v0.4.0 changelog (#138) * release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <[email protected]> * (build): added build-reproducible to makefile Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> * docs: Add link to consensus problems if you don't upgrade your node (#146) Co-authored-by: Federico Kunze Küllmer <[email protected]> * deps: bump SDK version (#147) * deps: bump SDK version * norace * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci: mergify changes (#152) * Fix `evmosd version` (#151) * build(deps): bump github.com/cosmos/ibc-go/v2 from 2.0.0 to 2.0.1 (#150) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.1/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build fix evmosd command * Update CHANGELOG.md Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <[email protected]> * app: fix typo in calculation of failed transactions in TPS value (#149) Noticed while I was auditing through evmosd code that inside the code that records TPS, that we have a typo in the calculation of nFailed, that instead used latestNSuccessful, of which if enough time is spent and the successful transactions have grown, while the number of failed transactions stays still, this can cause wrong TPS values to be reported. Co-authored-by: Federico Kunze Küllmer <[email protected]> * Update .goreleaser.yml (#156) * docs: block explorer (#158) * docs: quick facts table (#159) * docs: quick facts table * Update docs/basics/chain_id.md * changelog Co-authored-by: Daniel Burckhardt <[email protected]> Co-authored-by: Rohit Durvasula <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]> Co-authored-by: Prajjwol Gautam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <[email protected]>

codecov · 2021-12-12T02:54:08Z

Codecov Report

Merging #169 (84d71c2) into main (70e9d11) will increase coverage by 0.12%.
The diff coverage is 89.74%.

❗ Current head 84d71c2 differs from pull request most recent head b66ab94. Consider uploading reports for the commit b66ab94 to get more accurate results

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   72.43%   72.56%   +0.12%     
==========================================
  Files          24       24              
  Lines        1698     1724      +26     
==========================================
+ Hits         1230     1251      +21     
- Misses        416      421       +5     
  Partials       52       52

Impacted Files	Coverage Δ
app/app.go	`80.13% <0.00%> (-0.56%)`	⬇️
x/intrarelayer/types/utils.go	`38.88% <87.50%> (ø)`
x/intrarelayer/keeper/mint.go	`76.92% <100.00%> (-0.86%)`	⬇️
x/intrarelayer/keeper/proposals.go	`90.76% <100.00%> (+0.88%)`	⬆️

… fedekunze/erc20-fixes

danburck and others added 7 commits December 2, 2021 11:16

release: v0.4.0 changelog (#138)

6959ebe

* release(evmos): Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Federico Kunze Küllmer <[email protected]>

fix: upgrade handler for v0.4.1 (#166)

496deb4

fix: intrarelayer testnet fixes

fc9774d

fedekunze changed the title ~~fix: intrarelayer testnet fixes~~ fix: intrarelayer testnet bugs Dec 12, 2021

fix tests

bf9d8cf

fedekunze and others added 2 commits December 11, 2021 21:58

changelog

4a1631e

Merge branch 'main' into fedekunze/erc20-fixes

b1f653a

fedekunze marked this pull request as ready for review December 12, 2021 03:00

fedekunze requested review from jolube and khoslaventures as code owners December 12, 2021 03:00

fedekunze added 3 commits December 11, 2021 22:03

lint

7076601

Merge branch 'fedekunze/erc20-fixes' of github.com:tharsis/evmos into…

84d71c2

… fedekunze/erc20-fixes

comments

b66ab94

jolube approved these changes Dec 12, 2021

View reviewed changes

fedekunze enabled auto-merge (squash) December 12, 2021 03:19

fedekunze merged commit 882999d into main Dec 12, 2021

fedekunze deleted the fedekunze/erc20-fixes branch December 12, 2021 03:22

giansalex mentioned this pull request Dec 12, 2021

Interalayer : Register ERC20 #168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: intrarelayer testnet bugs #169

fix: intrarelayer testnet bugs #169

fedekunze commented Dec 12, 2021 •

edited

Loading

codecov bot commented Dec 12, 2021 •

edited

Loading

fix: intrarelayer testnet bugs #169

fix: intrarelayer testnet bugs #169

Conversation

fedekunze commented Dec 12, 2021 • edited Loading

codecov bot commented Dec 12, 2021 • edited Loading

Codecov Report

fedekunze commented Dec 12, 2021 •

edited

Loading

codecov bot commented Dec 12, 2021 •

edited

Loading