Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Arbitrary Tags Lightstep Tracing #4148

Closed
midnightconman opened this issue May 4, 2021 · 1 comment · Fixed by #4175
Closed

Allow Arbitrary Tags Lightstep Tracing #4148

midnightconman opened this issue May 4, 2021 · 1 comment · Fixed by #4175

Comments

@midnightconman
Copy link
Contributor

midnightconman commented May 4, 2021

Is your proposal related to a problem?

Not entirely, my proposal is related to a feature... one that would allow additional (arbitrary) tags to be added to the lightstep tracing configuration. The metadata that is passed to lightstep is pretty minimal, this would allow users to add more metadata (possibly that would match external labels?).

Describe the solution you'd like

I would like the option of adding key value pairs that match the opentracing.Tags object to the lightstep tracing configuration. This would be something like this:

      - args:
        - query
        - |
          --tracing.config=type: LIGHTSTEP
          config:
            tags:
              tag1: milkshake
              yard: boys
              "lightstep.env": prod

The opentracing.Tracer can take this in the options object.

Links:

Describe alternatives you've considered

Just leaving it as is and living with the lack of additional metadata?

Additional context

Links can be found in the Describe the solution you'd like section.

@onprem
Copy link
Member

onprem commented May 4, 2021

This looks straight-forward to implement. Contributions are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants