Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store gateway: Start metric server from the very start of the proces. #1653

Closed
bwplotka opened this issue Oct 15, 2019 · 1 comment · Fixed by #1656
Closed

store gateway: Start metric server from the very start of the proces. #1653

bwplotka opened this issue Oct 15, 2019 · 1 comment · Fixed by #1656
Labels
component: store difficulty: medium feature request/improvement

Comments

@bwplotka
Copy link
Member

bwplotka commented Oct 15, 2019 •
edited
Loading

Store Gateway exposes its /metric page only after initial sync. We should do it sooner. Since we have readiness probe now we can do it properly earlier!

We need to fix it as part of #1471 anyway, so this needs to be done ASAP.
@bwplotka bwplotka assigned bwplotka and unassigned bwplotka Oct 15, 2019
@bwplotka
Copy link
Member Author

This also affects liveness probes: We can only respond 200 until initial sync.

This was referenced Oct 15, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: store difficulty: medium feature request/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store: Start metric and status probe HTTP server as earlier as possible kakkoyun/thanos
1 participant
@bwplotka