Skip to content

Commit a38d67b

Browse files
committed
Fix tests
Signed-off-by: Filip Petkovski <[email protected]>
1 parent 4867335 commit a38d67b

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

inmem.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ func (b *InMemBucket) Attributes(_ context.Context, name string) (ObjectAttribut
213213
}
214214

215215
// Upload writes the file specified in src to into the memory.
216-
func (b *InMemBucket) Upload(_ context.Context, name string, r io.Reader) error {
216+
func (b *InMemBucket) Upload(_ context.Context, name string, r io.Reader, _ ...ObjectUploadOption) error {
217217
b.mtx.Lock()
218218
defer b.mtx.Unlock()
219219
body, err := io.ReadAll(r)

objstore_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func TestMetricBucket_UploadShouldPreserveReaderFeatures(t *testing.T) {
124124

125125
m := &mockBucket{
126126
Bucket: WrapWithMetrics(NewInMemBucket(), nil, ""),
127-
upload: func(ctx context.Context, name string, r io.Reader) error {
127+
upload: func(ctx context.Context, name string, r io.Reader, opts ...ObjectUploadOption) error {
128128
uploadReader = r
129129
return nil
130130
},
@@ -570,14 +570,14 @@ func (r *mockReader) Close() error {
570570
type mockBucket struct {
571571
Bucket
572572

573-
upload func(ctx context.Context, name string, r io.Reader) error
573+
upload func(ctx context.Context, name string, r io.Reader, opts ...ObjectUploadOption) error
574574
get func(ctx context.Context, name string) (io.ReadCloser, error)
575575
getRange func(ctx context.Context, name string, off, length int64) (io.ReadCloser, error)
576576
}
577577

578-
func (b *mockBucket) Upload(ctx context.Context, name string, r io.Reader) error {
578+
func (b *mockBucket) Upload(ctx context.Context, name string, r io.Reader, opts ...ObjectUploadOption) error {
579579
if b.upload != nil {
580-
return b.upload(ctx, name, r)
580+
return b.upload(ctx, name, r, opts...)
581581
}
582582
return errors.New("Upload has not been mocked")
583583
}

tracing/opentelemetry/opentelemetry.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func (t TracingBucket) Attributes(ctx context.Context, name string) (_ objstore.
110110
return t.bkt.Attributes(ctx, name)
111111
}
112112

113-
func (t TracingBucket) Upload(ctx context.Context, name string, r io.Reader) (err error) {
113+
func (t TracingBucket) Upload(ctx context.Context, name string, r io.Reader, opts ...objstore.ObjectUploadOption) (err error) {
114114
ctx, span := t.tracer.Start(ctx, "bucket_upload")
115115
defer span.End()
116116
span.SetAttributes(attribute.String("name", name))
@@ -120,7 +120,7 @@ func (t TracingBucket) Upload(ctx context.Context, name string, r io.Reader) (er
120120
span.RecordError(err)
121121
}
122122
}()
123-
return t.bkt.Upload(ctx, name, r)
123+
return t.bkt.Upload(ctx, name, r, opts...)
124124
}
125125

126126
func (t TracingBucket) Delete(ctx context.Context, name string) (err error) {

tracing/opentracing/opentracing.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,10 @@ func (t TracingBucket) Attributes(ctx context.Context, name string) (attrs objst
110110
return
111111
}
112112

113-
func (t TracingBucket) Upload(ctx context.Context, name string, r io.Reader) (err error) {
113+
func (t TracingBucket) Upload(ctx context.Context, name string, r io.Reader, opts ...objstore.ObjectUploadOption) (err error) {
114114
doWithSpan(ctx, "bucket_upload", func(spanCtx context.Context, span opentracing.Span) {
115115
span.LogKV("name", name)
116-
err = t.bkt.Upload(spanCtx, name, r)
116+
err = t.bkt.Upload(spanCtx, name, r, opts...)
117117
})
118118
return
119119
}

0 commit comments

Comments
 (0)