refactor code

Signed-off-by: milinddethe15 <[email protected]>

Author: milinddethe15

providers/azure/helpers.go

@@ -20,8 +20,6 @@ import (
 const DirDelim = "/"
 
 func getContainerClient(conf Config) (*container.Client, error) {
-	// Check if a roundtripper has been set in the config
-	// otherwise build the default transport.
 	var rt http.RoundTripper
 	rt, err := exthttp.DefaultTransport(conf.HTTPConfig)
 	if err != nil {

providers/bos/bos.go

@@ -66,7 +66,7 @@ func parseConfig(conf []byte) (Config, error) {
 
 // NewBucket new bos bucket.
 func NewBucket(logger log.Logger, conf []byte, component string) (*Bucket, error) {
-	//TODO: Add support for custom roundtripper.
+	// TODO(https://github.com/thanos-io/objstore/pull/140): Add support for custom roundtripper.
 	if logger == nil {
 		logger = log.NewNopLogger()
 	}

providers/gcs/gcs_test.go

@@ -161,7 +161,6 @@ http_config:
 }
 
 func TestNewBucketWithErrorRoundTripper(t *testing.T) {
-	// Create an error RoundTripper.
 	rt := &errutil.ErrorRoundTripper{Err: errors.New("RoundTripper error")}
 	cfg := Config{
 		Bucket:         "test-bucket",

providers/obs/obs.go

@@ -75,7 +75,7 @@ type Bucket struct {
 }
 
 func NewBucket(logger log.Logger, conf []byte) (*Bucket, error) {
-	//TODO: Add support for custom roundtripper.
+	// TODO(https://github.com/thanos-io/objstore/pull/140): Add support for custom roundtripper.
 	config, err := parseConfig(conf)
 	if err != nil {
 		return nil, errors.Wrap(err, "parsing cos configuration")

providers/oci/oci_test.go

@@ -11,8 +11,7 @@ import (
 )
 
 func TestNewBucketWithErrorRoundTripper(t *testing.T) {
-
-	mockPrivateKey := `-----BEGIN RSA PRIVATE KEY-----
+	const mockPrivateKey = `-----BEGIN RSA PRIVATE KEY-----
 MIICXgIBAAKBgQDCFENGw33yGihy92pDjZQhl0C36rPJj+CvfSC8+q28hxA161QF
 NUd13wuCTUcq0Qd2qsBe/2hFyc2DCJJg0h1L78+6Z4UMR7EOcpfdUE9Hf3m/hs+F
 UR45uBJeDK1HSFHD8bHKD6kv8FPGfJTotc+2xjJwoYi+1hqp1fIekaxsyQIDAQAB

providers/oss/oss.go

@@ -173,7 +173,6 @@ func NewBucketWithConfig(logger log.Logger, config Config, component string, rt
 	}
 	client, err := alioss.New(config.Endpoint, config.AccessKeyID, config.AccessKeySecret)
 	if rt != nil {
-		// custom RoundTripper
 		clientOption := func(client *alioss.Client) {
 			client.HTTPClient = &http.Client{Transport: rt}
 		}

providers/oss/oss_test.go

@@ -11,14 +11,12 @@ import (
 )
 
 func TestNewBucketWithErrorRoundTripper(t *testing.T) {
-
-	var config Config
-	config.Endpoint = "http://test.com/"
-	config.AccessKeyID = "123"
-	config.AccessKeySecret = "123"
-	config.Bucket = "test"
-	config.AccessKeySecret = "123"
-
+	config := Config{
+		Endpoint:        "http://test.com/",
+		AccessKeyID:     "123",
+		AccessKeySecret: "123",
+		Bucket:          "test",
+	}
 	rt := &errutil.ErrorRoundTripper{Err: errors.New("RoundTripper error")}
 
 	bkt, err := NewBucketWithConfig(log.NewNopLogger(), config, "test", rt)