fix objstore_bucket_operation_duration_seconds metrics

siavashs · siavashs · commit 31c0873d5266 · 2024-10-28T15:51:08.000+01:00
fix histogram metrics for `get` and `getrange` operations.

Signed-off-by: Siavash Safi &lt;siavash@cloudflare.com&gt;
diff --git a/objstore.go b/objstore.go
@@ -573,7 +573,7 @@ func (b *metricBucket) Get(ctx context.Context, name string) (io.ReadCloser, err
 		if !b.metrics.isOpFailureExpected(err) && ctx.Err() != context.Canceled {
 			b.metrics.opsFailures.WithLabelValues(op).Inc()
 		}
-		b.metrics.opsDuration.WithLabelValues(op).Observe(float64(time.Since(start)))
+		b.metrics.opsDuration.WithLabelValues(op).Observe(time.Since(start).Seconds())
 		return nil, err
 	}
 	return newTimingReader(
@@ -600,7 +600,7 @@ func (b *metricBucket) GetRange(ctx context.Context, name string, off, length in
 		if !b.metrics.isOpFailureExpected(err) && ctx.Err() != context.Canceled {
 			b.metrics.opsFailures.WithLabelValues(op).Inc()
 		}
-		b.metrics.opsDuration.WithLabelValues(op).Observe(float64(time.Since(start)))
+		b.metrics.opsDuration.WithLabelValues(op).Observe(time.Since(start).Seconds())
 		return nil, err
 	}
 	return newTimingReader(

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ func (b *metricBucket) Get(ctx context.Context, name string) (io.ReadCloser, err`
`573`	`573`	`if !b.metrics.isOpFailureExpected(err) && ctx.Err() != context.Canceled {`
`574`	`574`	`b.metrics.opsFailures.WithLabelValues(op).Inc()`
`575`	`575`	`}`
`576`		`- b.metrics.opsDuration.WithLabelValues(op).Observe(float64(time.Since(start)))`
	`576`	`+ b.metrics.opsDuration.WithLabelValues(op).Observe(time.Since(start).Seconds())`
`577`	`577`	`return nil, err`
`578`	`578`	`}`
`579`	`579`	`return newTimingReader(`
`@@ -600,7 +600,7 @@ func (b *metricBucket) GetRange(ctx context.Context, name string, off, length in`
`600`	`600`	`if !b.metrics.isOpFailureExpected(err) && ctx.Err() != context.Canceled {`
`601`	`601`	`b.metrics.opsFailures.WithLabelValues(op).Inc()`
`602`	`602`	`}`
`603`		`- b.metrics.opsDuration.WithLabelValues(op).Observe(float64(time.Since(start)))`
	`603`	`+ b.metrics.opsDuration.WithLabelValues(op).Observe(time.Since(start).Seconds())`
`604`	`604`	`return nil, err`
`605`	`605`	`}`
`606`	`606`	`return newTimingReader(`