This repository has been archived by the owner on Jul 30, 2020. It is now read-only.
Fix for console.error argument not being a string #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents asyncAct throwing an error if the item being logged isn't a string. Coped mostly from testing-library/react-testing-library#476
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 268 268
Branches 67 67
=====================================
Hits 268 268Continue to review full report at Codecov.
|
|
@allcontributors please add @AEgan for code |
|
I've put up a pull request to add @AEgan! 🎉 |
|
@bcarroll22 when can we expect a new release that includes this PR? |
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents asyncAct throwing an error if the item being logged isn't a string.
Coped mostly from testing-library/react-testing-library#476
What:
Following a similar PR made in react-testing-library, this fixes an issue where act-compat assumed console.error was being called with a string.
Why:
Current implementation assumes console.error was always called with a string even though it could be called with other types.
How:
Wrapped execution of code in a type check if statement to ensure operations are done only on string types.
Checklist:
docs site